Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem with Fitzhugh nagumo eqn #6

Open
pgleeson opened this issue Sep 6, 2013 · 3 comments
Open

Problem with Fitzhugh nagumo eqn #6

pgleeson opened this issue Sep 6, 2013 · 3 comments

Comments

@pgleeson
Copy link
Member

pgleeson commented Sep 6, 2013

value="( (V - ((V^3) / 3)) - W + I) / SEC"
is ok,
value="(V - (V^3) / 3 - W + I) / SEC"
is not...
In https://github.com/NeuroML/NeuroML2/blob/master/NeuroML2CoreTypes/Cells.xml
@lisphacker
Copy link
Member

Maybe an issue with the op precedence? I'll check it out

@pgleeson
Copy link
Member Author

pgleeson commented Sep 6, 2013

Great. As you may have seen I've made some changes today and gotten a few of the NeuroML files working.

Regarding this bug, it may be good to add unit tests on expression parsing like there are for unit string checking: https://github.com/LEMS/pylems/blob/master/lems/test/test_units.py

pgleeson added a commit to NeuroML/NeuroML2 that referenced this issue Mar 6, 2014
@pgleeson
Minor change to FitzhughNagumo model to work with pylems, see LEMS/py…
9d62039 
…lems#6
@pgleeson
Copy link
Member Author

Rechecked and this is still an issue...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lisphacker @pgleeson