From 05d36def4fd01d567b187a0e75e885071509f01a Mon Sep 17 00:00:00 2001
From: Riyaz Haque <your-email@example.com>
Date: Mon, 29 Apr 2024 01:11:15 -0700
Subject: [PATCH] HIP implementation of kripke

---
 .../kripke/rocm/execute_experiment.tpl        |  5 ---
 experiments/kripke/rocm/ramble.yaml           | 45 ++++++++++---------
 2 files changed, 23 insertions(+), 27 deletions(-)

diff --git a/experiments/kripke/rocm/execute_experiment.tpl b/experiments/kripke/rocm/execute_experiment.tpl
index cda7e5bcb..89e73cf49 100755
--- a/experiments/kripke/rocm/execute_experiment.tpl
+++ b/experiments/kripke/rocm/execute_experiment.tpl
@@ -1,5 +1,4 @@
 #!/bin/bash
-#
 # Copyright 2023 Lawrence Livermore National Security, LLC and other
 # Benchpark Project Developers. See the top-level COPYRIGHT file for details.
 #
@@ -11,8 +10,4 @@
 
 cd {experiment_run_dir}
 
-{spack_setup}
-
-{experiment_setup}
-
 {command}
diff --git a/experiments/kripke/rocm/ramble.yaml b/experiments/kripke/rocm/ramble.yaml
index d22da9f3d..1085636ac 100644
--- a/experiments/kripke/rocm/ramble.yaml
+++ b/experiments/kripke/rocm/ramble.yaml
@@ -7,6 +7,7 @@ ramble:
   include:
   - ./configs/spack.yaml
   - ./configs/variables.yaml
+  - ./configs/modifier.yaml
 
   config:
     deprecated: true
@@ -17,37 +18,37 @@ ramble:
   applications:
     kripke:
       workloads:
-        problem1:
+        kripke:
           env_vars:
           variables:
-            p: 2
-            px: '{p}'
-            py: '{p}'
-            pz: '{p}'
-            n: ['55', '110']
-            nx: '{n}'
-            ny: '{n}'
-            nz: '{n}'
-            experiment_setup: ''
-            processes_per_node: ['4']
-            n_nodes: ['1', '2']
             n_ranks: '{processes_per_node} * {n_nodes}'
+            experiment_setup: ''
+            processes_per_node: ['8']
+            n_nodes: '1'
+            arch: 'HIP'
           experiments:
-            kripke_rocm_problem1_{n_nodes}_{n_ranks}_{px}_{py}_{pz}_{nx}_{ny}_{nz}:
+            kripke_rocm_{n_nodes}_{ngroups}_{gs}_{nquad}_{ds}_{lorder}_{nzx}_{nzy}_{nzz}_{npx}_{npy}_{npz}:
               variables:
-                env_name: kripke
-              matrices:
-                - size_jobs:
-                  - n # TODO: Filter matrix
-                  - n_nodes # TODO: Filter matrix
+                ngroups: 64
+                gs: 1
+                nquad: 128
+                ds: 128
+                lorder: 4
+                nzx: '64'
+                nzy: '64'
+                nzz: '64'
+                npx: '2'
+                npy: '2'
+                npz: '2'
   spack:
     concretized: true
     packages:
-      kripke-rocm:
-        spack_spec: kripke@updateRCU2024.02 +mpi+rocm
+      kripke:
+        spack_spec: kripke@develop +mpi+rocm{modifier_spack_variant} ^chai@2024.02
         compiler: default-compiler
     environments:
-      kripke-rocm:
+      kripke:
         packages:
         - default-mpi
-        - kripke-rocm
+        - kripke
+        - '{modifier_package_name}'