-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IndexRegistry does not update currentOperatorIndex
when an operator is deregistered, in certain cases
#126
Comments
Sidenote, I feel like I better understand what the And now going back through the |
Also sidenote, thinking about a fix for this issue, I'm remembering having had this conversation already. I think the gist was that we don't have an "index does not exist" index - and that operators that have never registered have I'm not sure what the solution is, but maybe some context on how |
actually, noting here that |
Ideally we would have We'd then need to 1-index everything in the |
We discussed some offline, but to summarize my views, I think this behavior is OK (pretty much for the reasons you've outlined above), just needs documentation on the proper usage -- I'd hate to see someone integrate with this code incorrectly. |
Came across this while working on documentation:
eigenlayer-middleware/src/IndexRegistry.sol
Lines 99 to 106 in ebe657e
If
operatorId == lastOperatorId
, we never assigncurrentOperatorIndex[operatorId]
.To fix this, we can change
_popLastOperator
or add anelse
conditionThe text was updated successfully, but these errors were encountered: