Cleanup: unify typing of state variables in StakeRegistryStorage

[wadealexc]

eigenlayer-middleware/src/StakeRegistryStorage.sol

Lines 30 to 35 in ebe657e

	/// @notice In order to register for a quorum i, an operator must have at least `minimumStakeForQuorum[i]`
	/// evaluated by this contract's 'VoteWeigher' logic.
	uint96[256] public minimumStakeForQuorum;
	/// @notice array of the history of the total stakes for each quorum -- marked as internal since getTotalStakeFromIndex is a getter for this
	StakeUpdate[][256] internal _totalStakeHistory;

This is the only place in the middleware contracts where we use [256] to represent quorum information. I'd like to replace this with a mapping for consistency. I don't think it actually impacts a single thing, but if it this ends up breaking things it's fine to keep as-is.

[ChaoticWalrus]

I think this suggestion is fine.
obviously it's a breaking storage change for upgradeability purposes, so now seems like the right time to make the change 😅

[wadealexc]

I think this suggestion is fine. obviously it's a breaking storage change for upgradeability purposes, so now seems like the right time to make the change 😅

Oh right, I didn't think about upgrading our Goerli contracts - would need to add some deprecated variables to make up the space.

[ChaoticWalrus]

Oh right, I didn't think about upgrading our Goerli contracts - would need to add some deprecated variables to make up the space.

Aren't we already planning on redeploying because of other breaking storage layout / semantic changes? This strikes me as the last opportunity to reasonably make the change.

[wadealexc]

Oh right, I didn't think about upgrading our Goerli contracts - would need to add some deprecated variables to make up the space.

Aren't we already planning on redeploying because of other breaking storage layout / semantic changes? This strikes me as the last opportunity to reasonably make the change.

Will make sure I get a PR open for this today. I wanted to get the integration tests to a good state before I touched the contracts much more