chore: repo cleanup #139
Merged
chore: repo cleanup #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oordinatorStorage into separate contract
wadealexc
changed the title
src/RegistryCoordinator.sol
Outdated
Comment on lines
119
to
120
| * @notice Registers msg.sender as an operator for one or more quorums. If any quorum excees its maximum | ||
| * operator capacity after the operator is registered, this method will fail. |
There was a problem hiding this comment.
typo: excees => exceeds
src/RegistryCoordinator.sol
Outdated
| * they are deregistered. | ||
| * @notice Updates the StakeRegistry's view of one or more operators' stakes. If any operator | ||
| * is found to be below the minimum stake for the quorum, they are deregistered. | ||
| * @dev stakes are queryed from the Eigenlayer core DelegationManager contract |
There was a problem hiding this comment.
quark-sized nit but I believe it should be queried instead of queryed
There was a problem hiding this comment.
same comment on updateOperatorsForQuorum 😅
| * @dev stakes are queryed from the Eigenlayer core DelegationManager contract | ||
| * @param operatorsPerQuorum for each quorum in `quorumNumbers`, this has a corresponding list of operators to update. | ||
| * @dev Each list of operator addresses MUST be sorted in ascending order | ||
| * @dev Each list of operator addresses MUST represent the entire list of registered operators for the corresponding quorum |
There was a problem hiding this comment.
might not hurt to acknowledge the potential race condition here? (i.e. if an operator registers/deregisters, it can cause this to revert)
src/RegistryCoordinator.sol
Outdated
Comment on lines
519
to
520
| * @dev In order to be churned, the existing operator needs to have less stake than | ||
| * the total quorum stake by a propertion given by `kickBIPsOfTotalStake` |
There was a problem hiding this comment.
typo in propertion
I think this wording may also be a little confusing?
I would say instead:
* @dev In order to be churned out, the existing operator needs to have a proportion of the total
* quorum stake less than `kickBIPsOfTotalStake`
but perhaps that's just my personal preference
src/RegistryCoordinator.sol
Outdated
| blsApkRegistry.deregisterOperator(operator, quorumNumbers); | ||
| stakeRegistry.deregisterOperator(operatorId, quorumNumbers); | ||
| indexRegistry.deregisterOperator(operatorId, quorumNumbers); | ||
| } | ||
|
|
||
| /** | ||
| * @notice update operator stake for specified quorumsToUpdate, and deregister if necessary | ||
| * does nothing if operator is not registered for any quorums. | ||
| * @notice Updates the StakeRegistry's view of the operator's stake one or more quorums. |
There was a problem hiding this comment.
I feel like there's a word missing. perhaps "in one or more quorums"?
ChaoticWalrus
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currentOperatorIndexwhen an operator is deregistered, in certain cases #126quorumNumbersis non-empty #136