You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
My thoughts here:
I think this inconsistency is likely acceptable, but I do have a preference for consistency in general.
In this particular instance, I can see reducing a strategy multiplier to zero as perhaps a temporary measure / taken instead of removing a strategy from the list (e.g. in the case of an apparent infinite mint bug in the underlying token), while I don't see any case in which you would want to add a strategy with zero multiplier. However, it does feel like the correct action would be to remove the strategy from consideration, rather than reducing its multiplier to zero :|
I'm cool with adding the check to the modifyStrategyParams function -- maybe the revert message could just helpfully instruct to use the removeStrategies (or whatever its called) function instead?
_addStrategyParams
requires that multipliers are nonzero:eigenlayer-middleware/src/StakeRegistry.sol
Lines 416 to 419 in ebe657e
modifyStrategyParams
does not have this check:eigenlayer-middleware/src/StakeRegistry.sol
Lines 269 to 273 in ebe657e
Not a huge deal, but something we should consider changing for consistency.
The text was updated successfully, but these errors were encountered: