Feat/#44/자동 매칭 로직 버그 수정 및 sse 구독 로직 수정 #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huncozyboy
reviewed
Jan 22, 2025
| "FUNCTION('ST_Distance_Sphere', FUNCTION('POINT', :startLongitude, :startLatitude), FUNCTION('POINT', r.route.startLongitude, r.route.startLatitude)) <= :radius " + | ||
| "AND FUNCTION('ST_Distance_Sphere', FUNCTION('POINT', :destinationLongitude, :destinationLatitude), FUNCTION('POINT', r.route.endLongitude, r.route.endLatitude)) <= :radius ") | ||
| "WHERE " + | ||
| "FUNCTION('ST_Distance_Sphere', FUNCTION('POINT', :startLatitude, :startLongitude), FUNCTION('POINT', r.route.startLatitude, r.route.startLongitude)) <= :radius " + |
There was a problem hiding this comment.
기존 내용과 비교했을떄, 쿼리에서 startLatitude와 startLongitude의 순서가 수정된 것을 확인했습니다
저는 기존 기능과 동일하게 작동할 것으로 생각했는데, 혹시 순서 변경이 성능 개선이나 버그 수정 등
다른 목적이 있었는지 궁금합니다. 만약 제가 이해하지 못한 부분이라면, 변경하신 의도에 대해 간단히 공유해 주실 수 있을까요 ??
There was a problem hiding this comment.
SQL에서는 latitude, longitude 순서로 파라미터를 받아요!!
순서가 바뀌면 경도 (0360) 값이 위도 (-9090) 값으로 잘못 들어가게되어 SqlException이 발생합니다!!
Comment on lines
+37
to
+41
| this.sseService.sendToClient( | ||
| event.roomMasterId(), | ||
| "MATCH_ROOM_CREATED", | ||
| MatchRoomCreatedEvent.of(event, roomId) | ||
| ); |
There was a problem hiding this comment.
해당 부분이 아래의 코멘트에서 얘기했었던 부분입니다 !
매칭방 생성시, SSE로 클라이언트에게 방장의 ID까지 포함시켜서 반환해주는 플로우로 이해했습니다
| @@ -49,7 +49,7 @@ public class MatchingRoomService { | |||
| // event factory | |||
| private final MatchingEventFactory matchingEventFactory; | |||
|
|
|||
| public void createMatchingRoom(MatchRoomCreatedEvent matchRoomCreatedEvent) { | |||
| public Long createMatchingRoom(MatchRoomCreatedEvent matchRoomCreatedEvent) { | |||
There was a problem hiding this comment.
기존에 void였던 반환 타입이 Long으로 변경된건, 새로생성된 MatchingRoom의 방장의 ID를 방 생성시, 이벤트에 포함해서 함께 반환해주기 위함으로 이해했는데 맞을까요 ??
hyxklee
approved these changes
Jan 23, 2025
koreaioi
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 관련 이슈
관련 이슈 번호 #44
Close #44
🚀 작업 내용
📸 스크린샷
📢 리뷰 요구사항