Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-frequency input records #49

Open
bemoody opened this issue Oct 5, 2021 · 2 comments · May be fixed by #125
Open

Multi-frequency input records #49

bemoody opened this issue Oct 5, 2021 · 2 comments · May be fixed by #125

Comments

@bemoody
Copy link

bemoody commented Oct 5, 2021

A minor issue is that it might be nice to read multi-frequency records at their original sampling rates.

(In the WFDB format, multi-frequency records are accommodated by storing multiple samples per "frame". For example, if the ECG is sampled at 250 Hz and ABP is 100 Hz, the frame frequency might be set to 50 Hz, and each frame would contain 5 samples of ECG and 2 samples of ABP.)

Currently, update_graph uses wfdb.rdsamp to read the signals, which downsamples all signals to the frame frequency:

record = wfdb.rdsamp(record_path, return_res=16)

A better approach might be to use wfdb.rdrecord instead, with the argument smooth_frames=False. However, as of wfdb-python v3.4.1, this doesn't work consistently with single-frequency records (see MIT-LCP/wfdb-python#313).

@Lucas-Mc
Copy link
Collaborator

Lucas-Mc commented Jun 24, 2022

Hi @bemoody , just wanted to circle back here to see if there's any updates that's happened with the WFDB-Python repo that would make reading all these files faster? I thought I saw you do something that made reading a specific case faster but not sure

EDIT: I do want to have a quick test using wfdb.rdrecord with smooth_frame=False on breadboard to see if it makes a difference or causes issues like you mentioned

@bemoody
Copy link
Author

bemoody commented Jul 3, 2022 via email

@Lucas-Mc Lucas-Mc linked a pull request Oct 16, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants