Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support authKeyExpires for expires based authentication #5

Open
supermomonga opened this issue Jun 18, 2018 · 3 comments
Open

Support authKeyExpires for expires based authentication #5

supermomonga opened this issue Jun 18, 2018 · 3 comments

Comments

@supermomonga
Copy link
Contributor

According to the document, it's not recommended to use nonce for authentication.

https://www.bitmex.com/app/apiKeysUsage#Authenticating-with-an-API-Key

The new recommended way to authenticate is to use expires fir signature calculation, and it's also supported in WebSocket API.

https://www.bitmex.com/app/wsAPI#Authentication

So we can add authKeyExpires method.

@supermomonga
Copy link
Contributor Author

@supermomonga
Copy link
Contributor Author

I'm working on this now.

Sign the initial upgrade request in the same manner you would sign other REST calls (api-* headers), or

This way is not working as expected. I'll send a ticket to the BitMEX support.

After connection, send an "authKeyExpires".

This way works fine at my local branch.

I'll send a Pull Request later.

@Marfusios
Copy link
Owner

Hello, ok, thank you.
Looking forward to PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants