Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config/database.py contains undefined environment variables #49

Open
Jelmergu opened this issue Jan 16, 2023 · 0 comments
Open

config/database.py contains undefined environment variables #49

Jelmergu opened this issue Jan 16, 2023 · 0 comments

Comments

@Jelmergu
Copy link

The database config file contains the following code

"host": env("MSSQL_DATABASE_HOST"),
"user": env("MSSQL_DATABASE_USER"),
"password": env("MSSQL_DATABASE_PASSWORD"),
"database": env("MSSQL_DATABASE_DATABASE"),
"port": env("MSSQL_DATABASE_PORT"),

which is used to get the configuration for a MSSQL database connection. The naming of the environment variables is not consistent with the rest of the config file, which all use a DB_* scheme, nor are these variables defined/mentioned in the .env.example file.

Suggestion is to either add these variables to the example file, or probably preferable, change the code to match the rest of the scheme

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant