Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New flag for providing base directory for mapping to URL #96

Open
tbarnes4 opened this issue Jan 13, 2021 · 1 comment
Open

New flag for providing base directory for mapping to URL #96

tbarnes4 opened this issue Jan 13, 2021 · 1 comment
Labels

Comments

@tbarnes4
Copy link

Is your feature request related to a problem? Please describe.
The documentation and code require that for the generation of the SIP products, the directory name where the bundle.xml file lives on our local disks is the same directory name used in the weblink. In the SBN/UMD situation this is not true and may never be true.

Describe the solution you'd like
Since you must specify the weblink root structure using the -b flag anyways, I ask to be required to add one extra directory name, therefore the complete path to where the bundle.xml file is found. This would then include the cases where the last directory name matches and where it does not match.

Describe alternatives you've considered

  1. Provide an new flag to do this. Either a flag to ignore the last directory in the bundle's local path when using the -b flag or a flag to replace the -b flag in operation that serves the same function as the -b flag by providing a weblink, but knows to ignore the last directory in the local path.

  2. Leave the burden on the node to create artificial structures to use the code (for instance soft links in Linux/Mac) or conform with the expected structure of the code in node's archive.

@tbarnes4 tbarnes4 added enhancement New feature or request requirement-needed labels Jan 13, 2021
@jordanpadams jordanpadams changed the title Assumed bundle directory name New flag for providing base directory for mapping to URL Jan 13, 2021
@jordanpadams
Copy link
Member

thanks @tbarnes4 for the feedback! do you have a workaround for this? or does this need to be prioritized into this build cycle?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ToDo
Development

No branches or pull requests

2 participants