You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
...so that I can allow for other known aliases for a context object to be used in a label
π Additional Details
Per #945 (bug closed in lieu of this new requirement):
I was running some m20 validations for testing, with the latest validate (3.5.1) and there is a new warning type, warning.label.context_ref_mismatch, which is problematic.
The warnings look like this:
{
"severity": "WARNING",
"type": "warning.label.context_ref_mismatch",
"line": 64,
"message": "Context reference name mismatch. Value: 'Mars2020' Expected one of: '[MARS 2020]'"
},
{
"severity": "WARNING",
"type": "warning.label.context_ref_mismatch",
"line": 74,
"message": "Context reference name mismatch. Value: 'Mars 2020' Expected one of: '[Perseverance]'"
},
{
"severity": "WARNING",
"type": "warning.label.context_ref_mismatch",
"line": 83,
"message": "Context reference name mismatch. Value: 'Cache Camera' Expected one of: '[ENGINEERING CAMERA SUITE (ECAM)]'"
}
Now, we have a problem because for m20 ecam, we specifically use the "instrument:mars2020.ecam" context product, which covers a whole bunch of individual cameras, and then use under Observing_System_Component to say exactly which camera it is.
+1
Another use case: we have a bunch of labels saying MARS_SCIENCE_LABORATORY but the name does not have the underscores, and in fact was changed to Mars Science Laboratory: Curiosity Rover in the EdWG working group's version, which no label has. Honoring aliases needs to be a hard requirement for this warning, which allows flexibility to change what the context product says without breaking existing labels.
Checked for duplicates
No - I haven't checked
π§βπ¬ User Persona(s)
Node Operator
πͺ Motivation
...so that I can allow for other known aliases for a context object to be used in a label
π Additional Details
Per #945 (bug closed in lieu of this new requirement):
I was running some m20 validations for testing, with the latest validate (3.5.1) and there is a new warning type, warning.label.context_ref_mismatch, which is problematic.
The warnings look like this:
Now, we have a problem because for m20 ecam, we specifically use the "instrument:mars2020.ecam" context product, which covers a whole bunch of individual cameras, and then use under Observing_System_Component to say exactly which camera it is.
Acceptance Criteria
Given
When I perform
Then I expect
βοΈ Engineering Details
See #945 for additional context
π I&T
No response
The text was updated successfully, but these errors were encountered: