Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat request: multi component observations #10

Open
hkershaw-brown opened this issue Jul 18, 2024 · 2 comments
Open

Feat request: multi component observations #10

hkershaw-brown opened this issue Jul 18, 2024 · 2 comments

Comments

@hkershaw-brown
Copy link
Member

hkershaw-brown commented Jul 18, 2024

Observations types that are components of a measurement need treating differently to regular obs types.

Example is U_WIND, V_WIND combined into horizontal wind

https://github.com/NCAR/DART/blob/c8ddfac035a39bbb24451ced3b0aa5410ac62494/assimilation_code/programs/obs_diag/threed_sphere/obs_diag.f90#L2940-L2942

https://github.com/NCAR/DART/blob/c8ddfac035a39bbb24451ced3b0aa5410ac62494/assimilation_code/programs/obs_diag/threed_sphere/obs_diag.f90#L2993-L3021

@hkershaw-brown hkershaw-brown changed the title Feat request: mult component observations Feat request: multi component observations Jul 20, 2024
@hkershaw-brown
Copy link
Member Author

defined in yaml?

acars_horizontal_wind:
  description: ACARS-derived Horizontal wind speed
  components:
    - acars_u_wind_component
    - acars_v_wind_component

sat_horizontal_wind:
  description: Satellite-derived horizontal wind speed
  components:
    - sat_u_wind_component
    - sat_v_wind_component

@hkershaw-brown
Copy link
Member Author

note on duplicate observations. Will need to deal with these when finding matching component types.

number of each type of obs

one

duplicates where lat, lon, vertical, time & observation value matches. I feel like these are actual duplicates.

two

This is matches but not for observation value. Obs in the same place and time, same type, different observation value. 12544 out of 107212 sat_u_wind (10% ish). Different measurements of the same thing?

three

This is looking at the SAT_U_WIND_COMPENT dups. Sorted by latitude so you can see the dups a bit easier.
four

hkershaw-brown added a commit that referenced this issue Jul 31, 2024
Now much faster. ~2s on one million obs.

There are some print statements to take a look at duplicate observations.
See
#10 (comment)
or discussion.

added another composite type (need a list of all of these)
@hkershaw-brown hkershaw-brown moved this to Todo in Roadmap to v1 Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant