Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to PRASCore.jl #39

Merged
merged 5 commits into from
Dec 20, 2024
Merged

Switch to PRASCore.jl #39

merged 5 commits into from
Dec 20, 2024

Conversation

josephmckinsey
Copy link
Collaborator

Given the recent changes in PRAS.jl, we can remove our copy of PRAS and substitute their own.

We also depend on PRASFiles.jl instead of just PRASCore.jl, but it's only for the exporting, which we could get rid of too.

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 76.92308% with 3 lines in your changes missing coverage. Please review.

Project coverage is 47.00%. Comparing base (dcb927a) to head (010964e).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
src/PRAS2PowerSystems.jl 0.00% 2 Missing ⚠️
src/PowerSystems2PRAS.jl 83.33% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #39      +/-   ##
==========================================
- Coverage   50.26%   47.00%   -3.27%     
==========================================
  Files          54       12      -42     
  Lines        3201      751    -2450     
==========================================
- Hits         1609      353    -1256     
+ Misses       1592      398    -1194     
Flag Coverage Δ
unittests 47.00% <76.92%> (-3.27%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/SiennaPRASInterface.jl 100.00% <100.00%> (ø)
src/util/parsing/PRAS_export.jl 83.33% <100.00%> (ø)
src/util/parsing/lines_and_interfaces.jl 100.00% <100.00%> (ø)
src/PowerSystems2PRAS.jl 81.53% <83.33%> (ø)
src/PRAS2PowerSystems.jl 0.00% <0.00%> (ø)

Copy link
Contributor

@scdhulipala scdhulipala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

I don't think there are any specific changes you need to make. Just made a few comments.

Should I just rebase dsc/cleanup off of this one?

Project.toml Show resolved Hide resolved
@josephmckinsey josephmckinsey merged commit eeced9c into main Dec 20, 2024
8 checks passed
@josephmckinsey josephmckinsey deleted the jm/use_prascore branch December 20, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants