Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Currency conversions disabled #236

Open
softwareengineerprogrammer opened this issue Jun 13, 2024 · 2 comments
Open

Currency conversions disabled #236

softwareengineerprogrammer opened this issue Jun 13, 2024 · 2 comments
Assignees
@softwareengineerprogrammer
Labels
bug Something isn't working

Comments

@softwareengineerprogrammer
Copy link
Collaborator

Currency conversions no longer work due to the forex API being taken down - see MicroPyramid/forex-python#149. An alternative currency conversion service/methodology will need to be implemented.
@softwareengineerprogrammer softwareengineerprogrammer added the bug Something isn't working label Jun 13, 2024
softwareengineerprogrammer referenced this issue in softwareengineerprogrammer/GEOPHIRES Jun 13, 2024
@softwareengineerprogrammer
Re-enable example1_outputunits (https://github.com/NREL/GEOPHIRES-X/i…
f1ed50a 
…ssues/18\?title\=Fix+example1_outputunits+test+case+-+unstable+results) with currency conversion disabled (https://github.com/NREL/GEOPHIRES-X/issues/236\?title\=Currency+conversions+not+working+)
This was referenced Jun 13, 2024
Closed
Merged
@softwareengineerprogrammer softwareengineerprogrammer changed the title Currency conversions not working Currency conversions disabled Jun 18, 2024
softwareengineerprogrammer added a commit to softwareengineerprogrammer/GEOPHIRES that referenced this issue Jun 20, 2024
@softwareengineerprogrammer
Strip out obsolete conversion cruft and tighten up boundaries around …
1b7e1c6 
…disabled currency conversion (NREL#236)
This was referenced Jun 21, 2024
Merged
Merged
softwareengineerprogrammer added a commit to softwareengineerprogrammer/GEOPHIRES that referenced this issue Jun 25, 2024
@softwareengineerprogrammer
Update currency conversion failure messages to reference NREL#236
be73076
Merged
softwareengineerprogrammer added a commit to softwareengineerprogrammer/GEOPHIRES that referenced this issue Jun 28, 2024
@softwareengineerprogrammer
Unit test disabled currency conversion exceptions (NREL#236)
a9619c3
This was referenced Jun 28, 2024
Merged
Merged
@malcolm-dsider
Copy link
Collaborator

Here is a possible solution for the currency conversion using Pint!

https://pint.readthedocs.io/en/stable/advanced/currencies.html

@softwareengineerprogrammer
Copy link
Collaborator Author

Recently I've noticed that the forex API URL is now redirecting to parking domains - assigned to myself to disable currency conversion from attempting to call the forex API at all since the acquisition of the domain by a third party now presents a security risk

This was referenced Oct 15, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@softwareengineerprogrammer softwareengineerprogrammer

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@softwareengineerprogrammer @malcolm-dsider