New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

default FTFY setting may induce undesirable results in some languages #476

Open

AtsunoriFujita opened this issue Jan 9, 2025 · 0 comments

Labels

AtsunoriFujita commented Jan 9, 2025

Is your feature request related to a problem? Please describe.
Huggingface points out that default FTFY settings induce undesirable results in Chinese and Japanese.
https://huggingface.co/datasets/HuggingFaceFW/fineweb-2#:~:text=v2.0.1%20(08%2D01,See%20here

Describe the solution you'd like
https://github.com/NVIDIA/NeMo-Curator/blob/main/nemo_curator/modifiers/unicode_reformatter.py
Set FTFY config within UnicodeReformatter.

This PR has been applied to datatrove.
https://github.com/huggingface/datatrove/pull/319/files

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

AtsunoriFujita added the enhancement label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment