Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Schools view displayed for admins but not super admins #127

Open
puqeko opened this issue Feb 11, 2021 · 1 comment
Open

Schools view displayed for admins but not super admins #127

puqeko opened this issue Feb 11, 2021 · 1 comment

Comments

@puqeko
Copy link
Member

puqeko commented Feb 11, 2021 •
edited
Loading

Seems counter intuitive to me, especially when super admins can add themselves as admins. Discovered while reviewing PR #125.

Requires changes to app/policies/school_policy.rb perhaps.

Screen Shot 2021-02-11 at 6 47 29 PM
@Holmes98
Copy link
Member

Nice find, has_role?(:admin) needs to be changed to is_admin?.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Holmes98 @puqeko