Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: legs and hips tracking #1

Open
FarzanAlipour opened this issue Nov 29, 2022 · 2 comments
Open

Feature: legs and hips tracking #1

FarzanAlipour opened this issue Nov 29, 2022 · 2 comments

Comments

@FarzanAlipour
Copy link

Hey,
I checked the repo and it is super nice!
I wanted to know if you have any plans to track legs and hips in this package
P.N : I have used the same logic for legs and hips but it is not as good as arms.

@Neleac
Copy link
Owner

Neleac commented Dec 2, 2022

I also tried using the same logic and the results are not great, see fullbody branch. I suspect the problem is the initial landmark-avatar alignment. I simply rotate the landmarks to match the hips by comparing 2 vectors, but this should actually be a 3D coordinate alignment calculation.

@FarzanAlipour
Copy link
Author

sorry for the delay.
I have checked the fullbody branch, and yes the results are not good.
I achieved a better result with caching the spine and hip upward direction in the Start and then calculate the FromToRotation for the cached vector and mediapipe* upward for hips and spine ( *which are calculated in a separate method)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants