Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@measure for async functions #19

Closed
singhabhilash opened this issue Mar 2, 2020 · 3 comments
Closed

@measure for async functions #19

singhabhilash opened this issue Mar 2, 2020 · 3 comments
Labels
enhancement good first issue

Comments

@singhabhilash
Copy link

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[x] Feature request
[ ] Documentation issue or request

Current behavior

@measure only works for synchronous functions at the moment. Will be a nice addition to make it work for async functions as well.

Expected behavior

@measure should work for both sync and async functions.
@NetanelBasal
Copy link
Owner

You're welcome to submit a PR

@ruowan
Copy link
Contributor

ruowan commented Jun 23, 2020 •
edited
Loading

I meet the same issue. I would like to add an async measure function.

@ruowan
Copy link
Contributor

ruowan commented Jun 23, 2020

#23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@NetanelBasal @singhabhilash @ruowan