Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI is failing on non-ubuntu systems #1301

Open
JuliaSprenger opened this issue Jun 28, 2023 · 3 comments · May be fixed by #1302
Open

CI is failing on non-ubuntu systems #1301

JuliaSprenger opened this issue Jun 28, 2023 · 3 comments · May be fixed by #1302

Comments

@JuliaSprenger
Copy link
Member

JuliaSprenger commented Jun 28, 2023

With the latest CI feature that permits to trigger the IO test on different OS, the tests are still failing for macos. The corresponding run on windows is here

This issue is referring to features introduced in #1295

@zm711
Copy link
Contributor

zm711 commented Jun 29, 2023

Sorry if this is completely off-base I'm just spit-balling here. Based on my reading it looks like git-annex could be contributing. It's a bit of a mess with the transition to Apple silicon (but I think Actions are still x64). I wonder if it's possible to just add git-annex to the environment_testing.yml file under dependencies. conda-forge packages git-annex, so this could (I hope?) help with Mac and Windows, but I'm not sure if that would negatively affect anything else with the build. Good luck!

@JuliaSprenger
Copy link
Member Author

Hi @zm711 In principle you are right, the issue is that the git-annex conda package you are referring to only exists for linux systems, so adding this package to the environment_testing.yml will again only work for linux systems. My next best guess would be to test the datalad installer to see if that manages to install git-annex on non-linux systems.

@zm711
Copy link
Contributor

zm711 commented Jun 29, 2023

Hey @JuliaSprenger--you're right I didn't see that the conda-forge was just for Linux (too bad!). It might be more work than it is worth, but you can also brew install git-annex for Macs (brew install git-annex) and the Runner for Macs says it has brew already installed. But then you would need extra logic in the test files to separate out Mac vs Linux. In fact the DataLad website recommends brew install datalad to automatically get the dependencies rather than other installation methods. The datalad-installer will try to use brew under the hood for Macs.

I'm really not sure how the Windows story will work for this.

@JuliaSprenger JuliaSprenger added this to the 0.13.0 milestone Jul 19, 2023
@apdavison apdavison modified the milestones: 0.13.0, 0.14.0 Feb 23, 2024
@alejoe91 alejoe91 modified the milestones: 0.14.0, 0.15.0 Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants