Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Protocol encoder makes a data copy #1

Open
NiteshKant opened this issue Oct 12, 2013 · 0 comments
Open

Custom Protocol encoder makes a data copy #1

NiteshKant opened this issue Oct 12, 2013 · 0 comments
Assignees

Comments

@NiteshKant
Copy link
Owner

The custom protocol encoder makes a data copy here: https://github.com/NiteshKant/netty-playground/blob/master/custom-protocol/src/main/java/com/netflix/custom/protocol/CustomProtocolEncoder.java#L44

Instead it can use a composite buffer to create the data, reusing the ByteBuffer that the attribute contains.

@ghost ghost assigned NiteshKant Oct 12, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant