Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flake: broken .?submodules=1 #11859

Closed
widlarizer opened this issue Nov 12, 2024 · 3 comments
Closed

flake: broken .?submodules=1 #11859

widlarizer opened this issue Nov 12, 2024 · 3 comments
Labels

Comments

@widlarizer
Copy link

widlarizer commented Nov 12, 2024

Describe the bug

I have been relying on nix build ".?submodules=1" -L to build OpenROAD.

Steps To Reproduce

Run nix build ".?submodules=1" -L

in reproducer repo

Expected behavior

I would expect behavior as it was recently, that is, for . to use the current directory as-is, and for submodules=1 to include all submodules, and therefore to find the C file. Instead you get > cc1: fatal error: just-hello-c/hello.c: No such file or directory

nix-env --version output

nix-env (Nix) 2.24.10

(on NixOS unstable)

@widlarizer widlarizer added the bug label Nov 12, 2024
@nixos-discourse
Copy link

This issue has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/get-nix-flake-to-include-git-submodule/30324/21

@widlarizer
Copy link
Author

Adding a hash fixes this: nix build ".?submodules=1#" -L

@donn
Copy link
Member

donn commented Nov 12, 2024

The hash issue is being tracked here: #6633

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants