Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azure-agent: waagent.conf is hardcoded #272460

Closed
flokli opened this issue Dec 6, 2023 · 1 comment · Fixed by #362101
Closed

azure-agent: waagent.conf is hardcoded #272460

flokli opened this issue Dec 6, 2023 · 1 comment · Fixed by #362101
Assignees
@codgician
Labels
0.kind: bug Something is broken

Comments

@flokli
Copy link
Contributor

flokli commented Dec 6, 2023

Describe the bug

nixos/modules/virtualisation/azure-agent.nix currently configures a /etc/waagent.conf file with some hard-coded options.
It should probably be made overridable, probably by adopting RFC42.

While at it, we should probably compare the config with other distros, and see what defaults make sense for us.

Notify maintainers

@asmundo @Atry

Add a 👍 reaction to issues you find important.
@flokli flokli added the 0.kind: bug Something is broken label Dec 6, 2023
@codgician codgician mentioned this issue Dec 5, 2024
Merged
13 tasks
@codgician codgician self-assigned this Dec 5, 2024
@codgician
Copy link
Member

codgician commented Dec 6, 2024 •
edited
Loading

I created PR #362101 as an attempt to fix this issue. Feel free to review and please let me know your thoughts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@codgician codgician

Labels
0.kind: bug Something is broken
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

nixos/waagent: init module codgician/nixpkgs
2 participants
@flokli @codgician