Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update request: nexusmods-app 0.4.1 → 0.5.2 #317852

Closed
1 task done
l0b0 opened this issue Jun 6, 2024 · 5 comments
Closed
1 task done

Update request: nexusmods-app 0.4.1 → 0.5.2 #317852

l0b0 opened this issue Jun 6, 2024 · 5 comments
Labels
9.needs: package (update) This needs a package to be updated

Comments

@l0b0
Copy link
Contributor

l0b0 commented Jun 6, 2024

  • Package name: nexusmods-app

  • Latest released version: 0.5.2

  • Current version on the unstable channel: N/A

  • Current version on the stable/release channel: N/A

  • Checked the nixpkgs pull requests

Make sure to follow upstream package maintainers documentation.

Notify maintainers


Note for maintainers: Please tag this issue in your PR.


Add a 👍 reaction to issues you find important.

@l0b0 l0b0 added the 9.needs: package (update) This needs a package to be updated label Jun 6, 2024
@MisileLab
Copy link
Contributor

I think it should be on packaging request, not out-of-date package update.

@MattSturgeon
Copy link
Contributor

@MisileLab it was packaged in #270372 at v0.4.1, it just hasn't made nixos-unstable yet.

@l0b0
Copy link
Contributor Author

l0b0 commented Jun 9, 2024

Blocked by what seems like this issue:

nix-shell maintainers/scripts/update.nix --argstr package nexusmods-app

this derivation will be built:
  /nix/store/jq9mmjkarxdylc3w1rskhmfgm1adl9z3-packages.json.drv
building '/nix/store/jq9mmjkarxdylc3w1rskhmfgm1adl9z3-packages.json.drv'...

Going to be running update for following packages:
 - nexusmods-app-0.4.1

Press Enter key to continue...
Running update for:
 - nexusmods-app-0.4.1: UPDATING ...
 - nexusmods-app-0.4.1: ERROR

--- SHOWING ERROR LOG FOR nexusmods-app-0.4.1 ----------------------

cp: cannot stat '/tmp/deps-nexusmods-app-e6jxVa/home/.nuget/packages/*': No such file or directory


--- SHOWING ERROR LOG FOR nexusmods-app-0.4.1 ----------------------
The update script for nexusmods-app-0.4.1 failed with exit code 1

Update: Fixed by temporarily overriding the release name.

l0b0 added a commit to l0b0/nixpkgs that referenced this issue Jun 11, 2024
Also:

- Don't include upstream's 7zz binary
- Tell the app it is a distro package
- Document more of the build configuration
- Format using nixfmt-rfc-style

Closes NixOS#317852.

Co-authored-by: Matt Sturgeon <[email protected]>
l0b0 added a commit to l0b0/nixpkgs that referenced this issue Jun 11, 2024
Also:

- Don't include upstream's 7zz binary
- Tell the app it is a distro package
- Document more of the build configuration
- Format using nixfmt-rfc-style

Closes NixOS#317852.

Co-authored-by: Matt Sturgeon <[email protected]>
@l0b0 l0b0 changed the title Update request: nexusmods-app 0.4.1 → 0.5.1 Update request: nexusmods-app 0.4.1 → 0.5.2 Jun 20, 2024
l0b0 added a commit to l0b0/nixpkgs that referenced this issue Jun 20, 2024
Also:

- Don't include upstream's 7zz binary
- Tell the app it is a distro package
- Document more of the build configuration
- Format using nixfmt-rfc-style

Closes NixOS#317852.

Co-authored-by: Matt Sturgeon <[email protected]>
Co-authored-by: GGG <[email protected]>
matejc pushed a commit to matejc/nixpkgs that referenced this issue Sep 6, 2024
Also:

- Don't include upstream's 7zz binary
- Tell the app it is a distro package
- Document more of the build configuration
- Format using nixfmt-rfc-style

Closes NixOS#317852.

Co-authored-by: Matt Sturgeon <[email protected]>
Co-authored-by: GGG <[email protected]>
@TornaxO7
Copy link
Contributor

TornaxO7 commented Sep 7, 2024

well, now 0.6.0 is out https://github.com/Nexus-Mods/NexusMods.App/releases/tag/v0.6.0 xD

@l0b0
Copy link
Contributor Author

l0b0 commented Sep 7, 2024

Closing in favour of #331150.

@l0b0 l0b0 closed this as completed Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
9.needs: package (update) This needs a package to be updated
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants