Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nix-update does not work with tags #367562

Closed
JohnRTitor opened this issue Dec 23, 2024 · 2 comments
Closed

nix-update does not work with tags #367562

JohnRTitor opened this issue Dec 23, 2024 · 2 comments
Labels
0.kind: bug Something is broken 6.topic: fetch 6.topic: updaters Tooling for (semi-)automated updating of packages

Comments

@JohnRTitor
Copy link
Contributor

JohnRTitor commented Dec 23, 2024

I am glad that there is a tag attribute now and r-ryantm is now auto replacing refs/tags/${version}, but this largely breaks nix-update-script as nix-update-script does not yet have support of tag. Upstream issue: Mic92/nix-update#304

This largely breaks auto update as a lot of packages rely on nix-update.

So can we just fix this or hold off any treewide change replacing rev = refs/tags with tag?

CC: @Atemu @Mic92

@JohnRTitor JohnRTitor added 0.kind: bug Something is broken 6.topic: fetch 6.topic: updaters Tooling for (semi-)automated updating of packages labels Dec 23, 2024
@Atemu
Copy link
Member

Atemu commented Dec 23, 2024

Someone just needs to PR a fix. Holding off a treewide until that's done sounds like a sane idea to me. As mentioned previously, there isn't any great urgency to migrating to tags and waiting for stuff like this is something we should absolutely do.

I should perhaps communicated that clearer but the purpose of the initial PR was to establish the concept as an alternative to boilerplate that we should prefer, not to immediately roll it out as a breaking change.

@GaetanLepage
Copy link
Contributor

Fixed by #370820.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: bug Something is broken 6.topic: fetch 6.topic: updaters Tooling for (semi-)automated updating of packages
Projects
None yet
Development

No branches or pull requests

3 participants