Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: Custom Foundry installation location #535

Open
beepidibop opened this issue Dec 11, 2023 · 1 comment
Open

FR: Custom Foundry installation location #535

beepidibop opened this issue Dec 11, 2023 · 1 comment
Labels
foundry status:ready This issue is ready to be worked on

Comments

@beepidibop
Copy link

beepidibop commented Dec 11, 2023

My forge build is a bit messed up, the extension isn't picking up where my forge is even though where forge is working.

I see this was an issue here #354 but I didn't install with cargo, so my default installation location didn't line up with #366 or #515.

Submitting this feature request since the template for the PR asks me to discuss it in issues before submitting a PR. I have a branch ready for the PR if this is approved.

@oxcabe
Copy link

oxcabe commented Dec 16, 2023

I am also interested in this config feature, since Flatpak sandboxing is messing with the forge binary lookup:

Foundry project 'foundry-project' was not able to initialize correctly:
Error: Couldn't find forge binary. Performed lookup:
["forge","/home/oxcabe/.var/app/com.vscodium.codium/config/.foundry/bin/forge"]

If I were to request extra (or either implement it myself) for this feature, I'd ask for an additional "args" array config field to pass arguments to the forge binary. That way, it is not necessary to alter sandboxing permissions by calling /usr/bin/flatpak-spawn with forge as the positional argument.

@kanej kanej added status:ready This issue is ready to be worked on foundry and removed status:triaging labels Jul 29, 2024
@kanej kanej moved this to Todo in hardhat-vscode Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
foundry status:ready This issue is ready to be worked on
Projects
Status: Todo
Development

No branches or pull requests

3 participants