Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with blink usage, bots with blink getting stuck #217

Closed
Riveon opened this issue May 12, 2017 · 4 comments
Closed

Issues with blink usage, bots with blink getting stuck #217

Riveon opened this issue May 12, 2017 · 4 comments

Comments

@Riveon
Copy link

Riveon commented May 12, 2017

There seem to be issues with the calculation of blink direction, both for retreating when in danger, and initiating. In one case this led to LC getting stuck.
Here are some examples:
gfycat.com/VastEnergeticGermanpinscher
^After blinking, LC stayed here for three minutes even though she had blink and a tp (that wasn't on cd and that she had sufficient mana for). She finally teleported to her mid tier 2 tower once Dire started attacking it.
gfycat.com/PopularYellowishAmethystgemclam
gfycat.com/GrizzledBiodegradableBonobo (I'm guessing she intended to initiate here)

CsharpNoobDude pointed out in another thread:

Blink is weird in a lot of ways - probably the same reasoning as for some abilities like Invokers Alacrity - initiating but not committing to doing it.
Edit: The heroes blink in and then retreat, that is the case for about 50% of the blink uses....

@Nostrademous
Copy link
Owner

Yes, for retreat purposes I reversed my scaling calculations for mapping blink-to location resulting in a negative offset rather than a positive one, and as a result this makes them blink in the opposite direction.

For initiating purposes that should not happen as LC will blink directly to the targets current position vector.

@Nostrademous
Copy link
Owner

I fixed it "blind", meaning I fixed and pushed the code without testing it. Hopefully it doesn't break anything.

@Nostrademous
Copy link
Owner

Actually, while I fixed the scaling to be faster, it might not have been the issue as I was using Pythagorean calculation which makes absolute value anyways.

@Nostrademous
Copy link
Owner

Okay, fixes to fixes, tested and pushed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants