You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
we need to know whether refactoring the AlternativeImage selection logic out of Workspace.image_from_* into a stateless function (without any download_file behaviour) would break any existing API in the future, hence whether it must be done prior to 3.0 or can be done later.
@kba I don't think we need to break anything here in the future. The methods Workspace.image_from_page and Workspace.image_from_segment could be re-implemented as follows:
delegate to new generateds user methods PageType.get_image and [*Region|TextLine|Word]Type.get_image,
but pass as new kwarg resolve a function with the following definition:
replace calls to resolve_image_exif by calls to exif_from_filename directly,
but allow overriding filename via resolve
replace calls to resolve_image_as_pil by calls to a new function image_from_filename,
which merely contains the parts that do Image.open() and .load() to give up the FD, as well as array conversion for the badly supported color modes I and F,
but allow overriding filename via resolve
@kba I don't think we need to break anything here in the future. The methods
Workspace.image_from_page
andWorkspace.image_from_segment
could be re-implemented as follows:PageType.get_image
and[*Region|TextLine|Word]Type.get_image
,but pass as new kwarg
resolve
a function with the following definition:resolve_image_exif
by calls toexif_from_filename
directly,but allow overriding filename via
resolve
resolve_image_as_pil
by calls to a new functionimage_from_filename
,which merely contains the parts that do
Image.open()
and.load()
to give up the FD, as well as array conversion for the badly supported color modes I and F,but allow overriding filename via
resolve
Originally posted by @bertsky in bertsky#21 (comment)
The text was updated successfully, but these errors were encountered: