Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quiver timeline - add sorting #46

Closed
3 tasks
MareenGeestmann opened this issue Dec 4, 2023 · 6 comments · Fixed by #90
Closed
3 tasks

Quiver timeline - add sorting #46

MareenGeestmann opened this issue Dec 4, 2023 · 6 comments · Fixed by #90
Assignees

Comments

@MareenGeestmann
Copy link

Add sorting

  • by each metric (up/down)
  • by gt label (a-z)
  • by year (newest/oldest)
@MareenGeestmann MareenGeestmann changed the title quiver frontend - add sorting Quiver timeline - add sorting Dec 4, 2023
@jfrer jfrer self-assigned this Jun 28, 2024
@jfrer
Copy link
Collaborator

jfrer commented Jun 28, 2024

Regarding filtering by year: each gt has a notBefore and a notAfter year. Currently the order will be the same weather we sort by notBefore or notAfter but this could theoretically change in the future. Should one of these attributes get priority?
Some (theoretical) example gts:

  • 1800-1900 vs. 1832-1864
  • 1800-1950 vs. 1801-1850
  • 1800-1900 vs. 1800-1850

-> which one should be considered "older"?
I would say the one with the oldest notBefore and if they are the same then the oldest notAfter.
By this definition the examples would be:

  • 1st older
  • 1st older
  • 2nd older

But some people might consider the 2nd one of the second example to be older.
What do you think @MareenGeestmann ?

@MareenGeestmann
Copy link
Author

Thank you for the explanation!
I agree with you. -> the one with the oldest notBefore and if they are the same then the oldest notAfter.

@jfrer
Copy link
Collaborator

jfrer commented Jul 2, 2024

Should only the average of the latest runs be used for filtering by metric or the average of all runs? I assume only the latest runs but want to be sure.

@MareenGeestmann
Copy link
Author

Yes, only the latest run. And consider only the average (this might noch be optimal, but for this view fine enough; there is still the table view for more specific sorting [coming soon]).

@jfrer
Copy link
Collaborator

jfrer commented Jul 5, 2024

Okay, thanks!

I think ideally the sorting should only consider the average of all filtered workflows, but for this to be consistend with the average timeline chart the average timeline chart should also only consider the filtered workflows. So this switch might be better as a seperate task.

For now I will implement it to consider the average of the latest runs of all workflows.

@jfrer
Copy link
Collaborator

jfrer commented Jul 5, 2024

This is almost ready for pull request, i just need to wait for #81 to be merged so i can use these changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants