-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Viewer API in the Files app #445
Comments
I'd also really like to see Onlyoffice using Nextcloud's viewer frame, as this provides a way more obvious way for the users to close the editor. |
@violoncelloCH not like this would take a lot of effort -- as shown above, OnlyOffice does use the viewer API on the Dashboard, it's just a matter of making that behavior universal (and dropping whatever hack they're using on Files) |
@Thesola10 I believe that's something that the Dashboard does, not the Onlyoffice-Integration... but yes, would make sense of course to use the proper viewer api everywhere |
I just found out this integration app already has a Viewer API binding under js/viewer.js . What exactly is preventing js/editor.js from using the same mechanism? |
Or even better: just discontinue the Editor logic in favor of using Viewer exclusively -- declutters code, removes useless shortcuts from the OnlyOffice interface and fixes most layout issues in the Files app in one go |
Hello @Thesola10 @violoncelloCH
Is this still reproducible with the latest Document Server and connector versions?
Could you create a dedicated issue for that suggestion and elaborate on it? |
Thanks for the response @SergeyKorneyev
This is the same issue, on the latest release of Nextcloud (23 from NixOS), Document Server (from Docker Hub) and the Onlyoffice connector (from the App Store) on Firefox 95 Flatpak:
By "discontinuing the Editor logic", I meant (speculatively) that using the Viewer API on Nextcloud Files would standardize the way the connector works across Nextcloud and potentially allow the current Files overlay to be retired. I don't think it requires a separate issue. |
I've just noticed that, on my latest screenshot, part of the regular Files app's UI also appears to be broken -- I couldn't reproduce this without the OnlyOffice view open. |
Any updates? It looks like the Nextcloud 25 redesign might hinder the current overlay approach, so switching to Viewer everywhere is especially relevant I think |
Fixed in v7.8.0 |
Upgraded to 7.8.0 and it doesn't appear to use Viewer API frames on Files... does Document Server need to be updated as well? This issue isn't about the layout bugs in Files view, it's about using Viewer API everywhere |
Please consider reopening, the core issue still hasn't been addressed as of 8.x |
On the new Dashboard app, when selecting an Office file from the Files widget, OnlyOffice shows up in a window with a black top bar, the same being used on Nextcloud Text.
However, on Files, while NCText still uses that window, OnlyOffice attempts to overlay its editor in a weird way, which can cause graphical issues and obscures options to leave the editor or edit sharing settings, which are more obvious on NCText.
Please consider making it so the OnlyOffice editor uses the NCText-like frame on the Files app as well -- basically everywhere NCText does.
The text was updated successfully, but these errors were encountered: