Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MassBalance and EnergyBalance needs to be generalized. #19

Open
At11011 opened this issue Nov 27, 2024 · 0 comments
Open

MassBalance and EnergyBalance needs to be generalized. #19

At11011 opened this issue Nov 27, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@At11011
Copy link
Collaborator

At11011 commented Nov 27, 2024

In blocks.rs, we need to generalize the approach to track all streams entering and leaving the block for mass and energy balances. The following can be done:

  • Track all connectors, not just a single mass in-mass out value pairs
  • Compare relative error, for example, the total difference as compared to the total input. This should be an adjustable parameter similar to TOLERANCE_ENERGY and TOLERANCE_MASS, but should be dimensionless instead.
  • The mass_balance_check function should just take a &self reference, instead of actual value arguments. The blocks should contain references to Mconnectors and Econnectors (these I also believe should be revised, but that is a later issue).

I have included TODO's in the style-fix branch (to be uploaded in due time) that reference this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants