You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
After talking to @leewujung, we should modify apply_mask to enforce that the masks passed in are boolean masks.
Users can currently pass in masks that are 1/0 and 1/NaN, which stand for True/False; however, more obscure configurations can be passed in, such as arbitrary float/NaN, with the current way that apply_mask handles and applies masks onto Sv/MVBS data, and this makes it a bit confusing for what the user should pass in.
The text was updated successfully, but these errors were encountered:
After talking to @leewujung, we should modify
apply_mask
to enforce that the masks passed in are boolean masks.Users can currently pass in masks that are
1
/0
and1
/NaN
, which stand forTrue
/False
; however, more obscure configurations can be passed in, such asarbitrary float
/NaN
, with the current way thatapply_mask
handles and applies masks onto Sv/MVBS data, and this makes it a bit confusing for what the user should pass in.The text was updated successfully, but these errors were encountered: