Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

noopener noreferrer getting added every time even if "noopener noreferrer" already exist #280

Open
anupamamanish opened this issue Apr 11, 2023 · 4 comments

Comments

@anupamamanish
Copy link

anupamamanish commented Apr 11, 2023

  1. HTML we have before sanitize
    <a href="http://hcl.com" target="_blank">cool</a>
    after sanitize I am getting
    <a href="http://hcl.com" target="_blank" rel="noopener noreferrer">cool</a>

  2. If I have below code to sanitize
    <a href="http://hcl.com" target="_blank" rel="noopener noreferrer">cool</a>
    after sanitize
    <a href="http://hcl.com" target="_blank" rel="noopener noreferrer noopener noreferrer">cool</a>

The issue is "noopener noreferrer " gets appended every time we sanitize the html.

Expected result "noopener noreferrer " should not get appended if it is already present in the HTML

@anupamamanish anupamamanish changed the title noopener noreferrer getting appended every time even if "noopener noreferrer" already exist noopener noreferrer getting added every time even if "noopener noreferrer" already exist Apr 11, 2023
@anupamamanish
Copy link
Author

anupamamanish commented Jan 24, 2024 via email

@csware
Copy link
Contributor

csware commented Feb 2, 2024

Should be fixed on main.

@getnot
Copy link

getnot commented Mar 7, 2024

@csware Thank you for addressing the issue 🙏 .
I just want to inquire about the expected release date for these changes. If I'm not mistaken, the last release was conducted quite a while ago, back in 2022.

@pavelda2
Copy link

I'd also like to add a question to @mikesamuel, the author of the change, asking if a library release is planned in the near future. I would also appreciate the release of this patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants