Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*_vocabulary should point to terms instead of collection ? #221

Closed
vturpin opened this issue May 21, 2024 · 1 comment
Closed

*_vocabulary should point to terms instead of collection ? #221

vturpin opened this issue May 21, 2024 · 1 comment
Labels
1.0 For stuff that must be resolved before we are able to release 1.0

Comments

@vturpin
Copy link
Member

vturpin commented May 21, 2024

This has been raised in the PR #218

This issue aim to bring consistancy in the way we link users to controlled vocabulary and in the way we allow m2m approach.

I think we should guide the user the to controlled vocabulary collection, but in the data file the attribute should be the uri to the term and not the collection.
This is unclear at the moment in the document.

I suggest we clarify this by adding an attribute called *_vocabulary_collection that would be the link to the collection.

This should be applicable to all the controlled vocab that are mandatory : PLATFORM_MODEL, PLATFORM_MAKER, SENSOR_MODEL, SENSOR_TYPE, SENSOR_MAKER, PARAM

ex:
PLATFORM_MAKER:platform_maker_vocabulary_collection: https://vocab.nerc.ac.uk/collection/B75/current/ ?
PLATFORM_MAKER:platform_maker_vocabulary: https://vocab.nerc.ac.uk/collection/B75/current/ORG01077/" ?

Maybe I am wrong thinking that our reference to controlled vocabulary is unclear at the moment.

@vturpin vturpin added the 1.0 For stuff that must be resolved before we are able to release 1.0 label May 21, 2024
@vturpin
Copy link
Member Author

vturpin commented May 24, 2024

addressed in PR #233

@vturpin vturpin closed this as completed May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.0 For stuff that must be resolved before we are able to release 1.0
Projects
None yet
Development

No branches or pull requests

1 participant