-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PITCH, ROLL, HEADING, ALTITUDE OG1 vocabs missing definition #272
Comments
Thanks Emma! Here's some potential rewording: PITCH Also, re: the heading wording, some data flows may have the true north correction fairly early on in the processing. Do you want separate variable for true vs magnetic? |
Looking good ! for the true vs magnetic, as long as we choose one or the other it should be fine no ? |
A more general questions, should these definitions have units as @jenseva recommends? iirc there was some discussion before as to whether this is within the purview of OG1, or should be left out of this vocabulary for specification by the |
Hello all, thanks for the feedback! For the heading I would recommend creating separate OG1 terms for true vs magnetic so they can be distinguished, I can create this if required? R.e. units, we do map OG1 terms to a P06 term, but we encourage users to choose a P06 that is suitable for their dataset. Users shouldn't limit themselves to whatever P06 we have mapped to the OG1 term. I'm happy with the definitions above and can update the terms if everyone is happy with the above. |
Yeah please and it sounds like we are wanting two OG1 terms for heading. I'm not sure we should say 'typically measured' as the pref label includes 'by inclinometer' |
Yes I'd agree with you Emma r.e. the 'typically measured by' statement, as the term is specific to the method in this case inclinometer. The statement would be more suited to a more generic pref label that doesn't mention the method. |
@callumrollo @fmargirier @vturpin @jenseva @emmerbodc Happy New Year all, just coming back to this. R.e. the prefLabel for HEADING in OG1: I will need to update the P01 mapping. Currently it is mapped to https://vocab.nerc.ac.uk/collection/P01/current/HEADCM01/: Orientation (horizontal) of measurement device relative to True North {heading} Which refers to 'measurement device' and 'True North' as opposed to 'measurement platform' and 'magnetic north'. Therefore I will map OG1.HEADING to P01.HEADCMMG: https://vocab.nerc.ac.uk/collection/P01/current/HEADCMMG/ I will then create a new OG1 term for heading relative to True North, e.g.
And will need to create a new P01 term to map this to, e.g. Proposed definition for HEADING: Proposed definition for HEADINGTN: OG1.ROLL: https://vocab.nerc.ac.uk/collection/OG1/current/ROLL/ The P01 mapping will need to be updated from ROLLFG01to ROLLEI01 to reference 'inclinometer' rather than 'triaxial fluxgate compass': see http://vocab.nerc.ac.uk/collection/P01/current/ROLLEI01 Proposed OG1.ROLL definition: OG1.PITCH: https://vocab.nerc.ac.uk/collection/OG1/current/PITCH/ Again the P01 mapping will need to be updated from PTCHFG01 to PTCHEI01, to reference 'inclinometer' rather than 'triaxial fluxgate compass': see http://vocab.nerc.ac.uk/collection/P01/current/PTCHEI01 Proposed OG1.PITCH definition: OG1.ALTITUDE: https://vocab.nerc.ac.uk/collection/OG1/current/ALTITUDE/ Happy with P01 mapping. Proposed definition: If everyone is happy with the above I will add the new term and update the existing mappings and definitions. |
moderator: @OceanGlidersCommunity/format-maintainers
Hello @danibodc
It's been spotted that three of our terms in the OG1 vocab do not have definitions.
https://vocab.nerc.ac.uk/collection/OG1/current/PITCH/
https://vocab.nerc.ac.uk/collection/OG1/current/ALTITUDE/
https://vocab.nerc.ac.uk/collection/OG1/current/HEADING/
https://vocab.nerc.ac.uk/collection/OG1/current/ROLL/
Can these be added once agreement on the definitions please
@callumrollo @fmargirier @vturpin @jenseva @danibodc are you happy with these definitions below? I've copied the concept name.
PITCH
Orientation (pitch) of measurement platform by inclinometer
ROLL
Orientation (roll angle) of measurement platform by inclinometer
HEADING
Orientation (horizontal relative to magnetic north) of measurement platform {heading} by compass
ALTITUDE
Height above bed in the water body
Thanks,
Emma
The text was updated successfully, but these errors were encountered: