Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shorter? road to release #232

Open
44 of 46 tasks
tzarebczan opened this issue Jun 1, 2022 · 8 comments
Open
44 of 46 tasks

Shorter? road to release #232

tzarebczan opened this issue Jun 1, 2022 · 8 comments
Labels
enhancement New feature or request

Comments

@tzarebczan
Copy link
Contributor

tzarebczan commented Jun 1, 2022

Misc:

  • Odysee startup logo blurry. Maybe try: https://github.com/OdyseeTeam/odysee-android/blob/master/app/src/main/res/drawable-xxxhdpi/launch_screen.png (android 12 thing?)
  • use system default as the default theme
  • switched from system default to light mode + clicked back = app crash?
  • Sign up/in initial screen shows dark mode colors in lite mode (and throughout sign in/up process) Should keep theme.
  • "Use magic link" > "Use Magic Link via Email"
  • missing password reset - wait for Oauth?
  • Got stuck on wallet sync / retrieving account information... on initial sign in. Clicking back took me to homepage and was signed in.
  • notifications when following should not be turned on by default. confirm action on bell icon (turn on / off notifications)

Sync:

Publish Area:

  • when not signed in, drive sign up before allowing publish
  • remove suggested mature tags
  • review odysee.com publish experience (being revamped now). i.e. put certain things like bid / price into advanced. remove lbry://
  • How do I get back to see my uploads?

Thumbnails:

  • update thumbnail CDN to thumbnails.odycdn.com
  • use same sizes/quality as odysee.com in various areas - channel profiles / thumbnails / content pages (use same 390/220?), banners (no size?). Check network tab in various scenarios. i.e.
- https://thumbnails.odycdn.com/optimize/s:390:220/quality:85/plain/https://thumbs.odycdn.com/5d63c46cd92617a09c480b684fb4707e.jpg (content thumbs) 
- https://thumbnails.odycdn.com/optimize/s:100:0/quality:85/plain/https://thumbnails.lbry.com/UCxsNlGBU5SGtk7gjzC5rpXw (or 200:0 if 100 is too small) 

Claim previews :

  • check featured dates - some repost dates nothing coming through? see May 21, August 30, 2020, and "days ago" on various claims
  • Add channel profile thumbnail
  • Use Channel title if it exists, channel name if not.

Blocking:

  • was able to block without being signed in - this is more of a mute function. Real blocking requires an account. It does store in local state - need to confirm this syncs up.

Notifications:

  • when not signed in, drive sign up/in?

Playback related:

  • can't get back into content from bottom miniplayer (clicking doesn't do anything, can't swipe up). It seemed to work once.
  • When in miniplayer mode and navigating back to same claim, it restarts
  • When in miniplayer mode and navigating to another claim, it auto starts - should continue playing, and allow user to click play manually.
  • see spinner over pause button during initial video loads (hide pause, make spinner bigger/nicer?)

Reactions:

  • Clicking fire/slime on content or comments does nothing when not signed in does nothing (drive sign up / in )

Video player:

  • progress bar is short with all the new video options.
  • Hard to see rate/auto controls over the video
  • Hide Auto quality selector if there are no options available?
  • Maybe put options behind a cog (then you can show auto) Not needed.
  • Font sizes different between various video components (time / auto/rate)
  • when switching between videos, the original video is shown in the top left briefly (smaller version?)

Channel pages:

  • add view counts to all videos (can batch the view api)
  • can't infinite scroll to more pages on channel page
  • hide scheduled streams tab if there aren't any?

Livestreaming:

  • hide time elapsed / time remaining on livestreams (show otherwise)
  • For the livestream content date - use the started at from livestream api (and not claim date)
  • missing quality options under Auto (confirmed stream had em)
  • If someone changes playback rate, and then it catches up to the live tip, change rate back to 1x (otherwise you continue to get buffering cause it's trying to play faster). Hide rate playback for now on lives if not possible/difficult.
  • Following page - if you click Filter and then click on a channel, it stops showing active livestreams. If you click All, still doesn't show them. Need to leave and come back.

Publishing:

  • after publishing something, it went to a screen with "It looks like you have not published content to LBRY yet" with a New Publish button.
  • app reloading after accepting permissions to camera/audio when trying to go live .

Playlists:

  • @richardharriscoaching channel - when you click on a playlist, it shows null (circle) x / x
  • clicking Back from a playlist click takes you to channel page (should take you to playlist page?
  • Can click "Watch later" and other options on playlists - don't make sense?

Rewards:

  • prompt rewards approval or show pending message on rewards page
@tzarebczan tzarebczan added the enhancement New feature or request label Jun 1, 2022
@kekkyojin
Copy link
Collaborator

I will be working on three first issues.

Android 12 always shows the app icon when cold started. That’s why I chose to not show the splash screen from that version.

For consistency with default theme preferences on Odysee -at least originally-, I also chose light theme as default. I will be changing it into System Default.

@ktprograms
Copy link
Collaborator

can't get back into content from bottom miniplayer (clicking doesn't do anything, can't swipe up). It seemed to work once.

When in miniplayer mode and navigating back to same claim, it restarts

I haven't experienced these problems before. What version of Android are you using? Can you reproduce in the emulator?

@ktprograms
Copy link
Collaborator

app reloading after accepting permissions to camera/audio when trying to go live

I was able to reproduce it this morning, and the problem was exceptions in the Camera2Source within HaishinKit.kt. Now I can't seem to reproduce it, although I'll send a PR to upgrade HaishinKit to the latest tag in a while (after the JitPack artifacts get fixed).

@ktprograms
Copy link
Collaborator

@kekkyojin can't get back into content from bottom miniplayer (clicking doesn't do anything, can't swipe up). It seemed to work once. seems to be caused by commit dce3e8c Show appropriate UI when a claim is for a non-live livestream (#220).

I did a bit of debugging, and it seems like currentUrl is not set with calling setNowPlayingClaim, so openFileUrl isn't called when tapping the MiniPlayer card.

@ktprograms
Copy link
Collaborator

@tzarebczan For add view counts to all videos (can batch the view api), how is the batching done?

@ktprograms
Copy link
Collaborator

@tzarebczan What is Add channel profile (under Claim previews) meant to be?

@tzarebczan
Copy link
Contributor Author

@tzarebczan What is Add channel profile (under Claim previews) meant to be?

Fixed - meant channel profile thumbnail

@ktprograms
Copy link
Collaborator

@tzarebczan when switching between videos, the original video is shown in the top left briefly (smaller version?) Can't reproduce this. What exactly were you doing to have this happen?

ktprograms added a commit that referenced this issue Sep 23, 2022
UX flow:
- Clicking the Upload button shows menu to pick Upload or Go Live
- Create livestreams with form like publishing
- Choose New Livestream or Upload Replay
  Replays shown in pages of 4 like on odysee.com
- Choose Anytime or Scheduled Time stream
- Clicking the Create button goes to livestreams dashboard (also
  accessible from user menu)
- Livestreams dashboard shows stream server and stream key, with button
  to copy
- Dashboard waits for created claim to finish confirming then enables
  Start Streaming button
- Clicking Start Streaming goes to activity that streams with HaishinKit
- Streaming activity sets FLAG_KEEP_SCREEN_ON in onCreate instead of
  when streaming starts. Also removes flag only onDestroy.

Fix: #93
Fix: #94
Fix (partial): #232 (app reloading after accepting permissions to
camera/audio when trying to go live)
ktprograms added a commit that referenced this issue Sep 23, 2022
UX flow:
- Clicking the Upload button shows menu to pick Upload or Go Live
- Create livestreams with form like publishing
- Choose New Livestream or Upload Replay
  Replays shown in pages of 4 like on odysee.com
- Choose Anytime or Scheduled Time stream
- Clicking the Create button goes to livestreams dashboard (also
  accessible from user menu)
- Livestreams dashboard shows stream server and stream key, with button
  to copy
- Dashboard waits for created claim to finish confirming then enables
  Start Streaming button
- Clicking Start Streaming goes to activity that streams with HaishinKit
- Streaming activity sets FLAG_KEEP_SCREEN_ON in onCreate instead of
  when streaming starts. Also removes flag only onDestroy.

Fix: #93
Fix: #94
Fix (partial): #232 (app reloading after accepting permissions to
camera/audio when trying to go live)
ktprograms added a commit that referenced this issue Sep 23, 2022
UX flow:
- Clicking the Upload button shows menu to pick Upload or Go Live
- Create livestreams with form like publishing
- Choose New Livestream or Upload Replay
  Replays shown in pages of 4 like on odysee.com
- Choose Anytime or Scheduled Time stream
- Clicking the Create button goes to livestreams dashboard (also
  accessible from user menu)
- Livestreams dashboard shows stream server and stream key, with button
  to copy
- Dashboard waits for created claim to finish confirming then enables
  Start Streaming button
- Clicking Start Streaming goes to activity that streams with HaishinKit
- Streaming activity sets FLAG_KEEP_SCREEN_ON in onCreate instead of
  when streaming starts. Also removes flag only onDestroy.

Changes of note:
- There are now 3 publish tasks:
  - PublishClaimTask uses the LBRY API
  - ReplayPublishTask uses the v1 Odysee Publish API
  - TusPublishTask uses the v2 Odysee Publish API (uses Tus for upload)
- Add buildPublishOptions function in Helper to create options map from
  Claim.

Fix: #93
Fix: #94
Fix (partial): #232 (app reloading after accepting permissions to
camera/audio when trying to go live)
ktprograms added a commit that referenced this issue Sep 23, 2022
UX flow:
- Clicking the Upload button shows menu to pick Upload or Go Live
- Create livestreams with form like publishing
- Choose New Livestream or Upload Replay
  Replays shown in pages of 4 like on odysee.com
- Choose Anytime or Scheduled Time stream
- Clicking the Create button goes to livestreams dashboard (also
  accessible from user menu)
- Livestreams dashboard shows stream server and stream key, with button
  to copy
- Dashboard waits for created claim to finish confirming then enables
  Start Streaming button
- Clicking Start Streaming goes to activity that streams with HaishinKit
- Streaming activity sets FLAG_KEEP_SCREEN_ON in onCreate instead of
  when streaming starts. Also removes flag only onDestroy.

Changes of note:
- There are now 3 publish tasks:
  - PublishClaimTask uses the LBRY API
  - ReplayPublishTask uses the v1 Odysee Publish API
  - TusPublishTask uses the v2 Odysee Publish API (uses Tus for upload)
- Add buildPublishOptions function in Helper to create options map from
  Claim.

Fix: #93
Fix: #94
Fix (partial): #232 (app reloading after accepting permissions to
camera/audio when trying to go live)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants