Replace Ordering.explicit() with Comparator.comparing() #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
|
It seems java.util.Comparator hasn’t been included on the desugaring, and the comparing() method requires API Level 24, so I’m cancelling this PR but leaving the bug as opened |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check all that apply to this PR using "x":
PR Type
What kind of change does this PR introduce?
Fixes
Issue Number: #305
What is the current behavior?
Guava Ordering.explicit() is used which offers the same functionality that standard Comparator
What is the new behavior?
Standard Comparator is being used
Other information
From what I have seen, original code took a List as the sorting order for items, then sorts a List of claims so it matches the first List. This is now be done using Comparator.comparing() instead of using an external library.