-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detail view: References #1953
Comments
Overall, this design is meeting a TON of the needs that I can think of. There are a lot of positive things in here, and I generally have some smaller bits of feedback that hopefully won't disrupt this design too much. I don't have any additional comments for the Reference details tab, since I think it's displaying a lot of relevant info related to how the reference itself is built. I added some comments related to the following things for the View Expansion tab:
|
@jamlung-ri The designs have been revised, could you take a look at let me know if your feedback has been addressed? I removed 'Target Concepts' for now, I'm actually unsure what we're representing there, so let's discuss! |
@paulsonder I had one other comment on there about selecting an expansion for the View Expansion tab. But overall this design is looking good. This might be one that would benefit from Jon's input too, but I think the overall structure is working well. |
Is that handled with the Expansion picker design @jamlung-ri ? |
I think so! If we can just build in a way to select a different expansion somewhere, then I think this design is in good shape. If it helps, this window probably doesn't need the checkboxes that I see in the Expansion Picker design, but it doesn't hurt to leave them in either. |
User interfaces can be found here.
Please record any feedback that needs to be actioned before moving the Dev here.
For future requirements, let's capture in a separate ticket and prioritise accordingly.
The text was updated successfully, but these errors were encountered: