-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi-artist and multi-genre support #254
Comments
The weird thing about this is that it's just how the left menu is formatted; if you press the artist name (but only from, like, the artist name in the tracklist for some reason) it'll show a split album or whatever alongside all the other artist's releases. But this is still a big issue; it makes a lot of splits & multi-genre stuff hard to organize. |
@JadeTank Any idea how much effort it would take to implement support for multiple genres in the library filters? |
@shadeMe If you mean the ability for splitting entries based on a separator, probably not too much? This is something I looked into in the past when I was a lot less experienced and wasn't able to figure it out then, but its been a while since then and I think it shouldn't be too much work. The library is based on https://github.com/Wil-B/Library-Tree which doesn't support multi-value fields but I think as long as it can be modified to split on a delimiter it could work. For now what you can do is use the library tree, which can be set to view by genre and will split on multi value fields |
Been working on this and have 99% working, just a few kinks to work out like some issues with title format sorting & item thumbnails not using the first item, but the basic functionality works and should be completed then added in a few days :) |
I've attached the updated file here WSHfilter.zip Please try it out by swapping the existing js file under profile > themes > eole > js, then set the grouping / sorting to default, and your genres / artists will now be split :) I haven't found any issues using it thus far, please try it out and report if you can find any. If not, ill add it to the repo shortly. |
Found an issue w/ the cover being incorrect due to a wrong cachekey being set for split items, corrected. |
I haven't had a chance yet to test this out (will hopefully have some time over the weekend), but thanks very much for implementing this so quickly! I was prepared to take a crack it myself but seeing how it's been years since I looked at/worked with the code, you were definitely the best person for the job 😄 |
Anyone had a chance to try this out yet? |
I've been meaning to but need to first update my tags to support multiple genres. I can do a quick test tonight with some manually edited albums. |
Anyone been able to test it out yet? Ive been using it without any issues, will just push it if I don't hear any problems. |
Sorry about the radio silence - I did a quick test on my end, and it seems to work for multiple genres. Haven't tested multi-artist support though. |
It's annoying this isn't a feature in Eole, yet vanilla Foobar2000 is fine.
ALL of this is tagged with the semicolon as a separator.
The text was updated successfully, but these errors were encountered: