Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-artist and multi-genre support #254

Closed
Zetvue opened this issue Mar 21, 2023 · 11 comments · Fixed by #308
Closed

Multi-artist and multi-genre support #254

Zetvue opened this issue Mar 21, 2023 · 11 comments · Fixed by #308

Comments

@Zetvue
Copy link

Zetvue commented Mar 21, 2023

It's annoying this isn't a feature in Eole, yet vanilla Foobar2000 is fine.
image
image
image
image
ALL of this is tagged with the semicolon as a separator.

@magagonal
Copy link

The weird thing about this is that it's just how the left menu is formatted; if you press the artist name (but only from, like, the artist name in the tracklist for some reason) it'll show a split album or whatever alongside all the other artist's releases. But this is still a big issue; it makes a lot of splits & multi-genre stuff hard to organize.

@shadeMe
Copy link
Contributor

shadeMe commented Jul 31, 2024

@JadeTank Any idea how much effort it would take to implement support for multiple genres in the library filters?

@JadeTank
Copy link
Collaborator

@shadeMe If you mean the ability for splitting entries based on a separator, probably not too much? This is something I looked into in the past when I was a lot less experienced and wasn't able to figure it out then, but its been a while since then and I think it shouldn't be too much work. The library is based on https://github.com/Wil-B/Library-Tree which doesn't support multi-value fields but I think as long as it can be modified to split on a delimiter it could work.

For now what you can do is use the library tree, which can be set to view by genre and will split on multi value fields

@JadeTank
Copy link
Collaborator

JadeTank commented Aug 2, 2024

Been working on this and have 99% working, just a few kinks to work out like some issues with title format sorting & item thumbnails not using the first item, but the basic functionality works and should be completed then added in a few days :)

@JadeTank
Copy link
Collaborator

JadeTank commented Aug 4, 2024

I've attached the updated file here WSHfilter.zip

Please try it out by swapping the existing js file under profile > themes > eole > js, then set the grouping / sorting to default, and your genres / artists will now be split :)
Can also split groups on any tag by using the title formatting i.e. $meta_sep(album artist,';')

I haven't found any issues using it thus far, please try it out and report if you can find any. If not, ill add it to the repo shortly.

@JadeTank JadeTank linked a pull request Aug 5, 2024 that will close this issue
@JadeTank
Copy link
Collaborator

JadeTank commented Aug 5, 2024

Found an issue w/ the cover being incorrect due to a wrong cachekey being set for split items, corrected.

@shadeMe
Copy link
Contributor

shadeMe commented Aug 6, 2024

I haven't had a chance yet to test this out (will hopefully have some time over the weekend), but thanks very much for implementing this so quickly! I was prepared to take a crack it myself but seeing how it's been years since I looked at/worked with the code, you were definitely the best person for the job 😄

@JadeTank
Copy link
Collaborator

Anyone had a chance to try this out yet?

@shadeMe
Copy link
Contributor

shadeMe commented Aug 20, 2024

I've been meaning to but need to first update my tags to support multiple genres. I can do a quick test tonight with some manually edited albums.

@JadeTank
Copy link
Collaborator

Anyone been able to test it out yet? Ive been using it without any issues, will just push it if I don't hear any problems.

@shadeMe
Copy link
Contributor

shadeMe commented Sep 12, 2024

Sorry about the radio silence - I did a quick test on my end, and it seems to work for multiple genres. Haven't tested multi-artist support though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants