Strip catalog attributes - Optional reconstruction version. #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The failing test is what we discussed the other day with the |
RondeauG
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist:
save_to_*should remove catalog-dependent attributes. #499 and fixes Official path scheme for reconstruction shouldn't require a version. #500.number) and pull request (:pull:number) has been added.What kind of change does this PR introduce?
strip_cat_attrsutility to remove those attributes added by the catalog opening functions.save_to_zarrandsave_to_netcdf.build_path, added possibility to have aggregated folder levels with optional components.versionoptionnal in the non-sim schemas.Does this PR introduce a breaking change?
build_pathwill not fail on a reconstruction dataset missing a version.