Remove unit registry, use cf-xarray's or any other. #57
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist:
number
) and pull request (:pull:number
) has been added.What kind of change does this PR introduce?
cf-xarray
, but starting with xclim 0.55, once xclim is imported it will be xclim's.Quantity.magnitude
is a zero-dim array, but we expect a float. I cast them explicitly everywhere we handle this.cf
unit formatter is created but not set as default bycf-xarray
. I explicitly use it everywhere we cast to string.pct
for "percent" as this is not CF and not supported by cf-xarray.As we still expect CF outputs, this is not completely agnostic : the unit registry used must come from cf-xarray. But it does allow to use the one from xclim.
Does this PR introduce a breaking change?
Shouldn't.
Other information:
Once Ouranosinc/xclim#2040 is merged a simple
import xclim
should activate xclim's registry. Then, using the hydro context would look like:I will be adding a doc example soon.