Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extraction to paths outside output folder should fail by default #18

Open
DanRStevens opened this issue Apr 22, 2018 · 0 comments
Open

Comments

@DanRStevens
Copy link
Member

An archive with absolute paths, or relative paths with ".." to escape the output folder could wreak havoc on a user's system during extraction. This should be disabled by default.

Such an archive could be constructed by a malicious user using a third party tool. As such, the check would need to be done during extraction to be effective, and not simply during packing.

Consider:
/autoexec.bat
/config.sys
/Windows/System32/cmd.exe
/etc/passwd (Linux)
../../../../Windows/System32/cmd.exe

If extraction of such files is to be allowed, it should require explicit use of a command line switch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant