Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split off unused assets to separate folder #16

Open
DanRStevens opened this issue Dec 17, 2024 · 1 comment
Open

Split off unused assets to separate folder #16

DanRStevens opened this issue Dec 17, 2024 · 1 comment

Comments

@DanRStevens
Copy link
Member

DanRStevens commented Dec 17, 2024

As discussed on Discord, the release packages currently undergo some manual stripping of unused assets. Those assets are planned for future use, so we don't want to remove them from the repository, though we would like an easy way to strip unused assets for the purpose of automated release packaging.

One possibility is to manually move unused assets to a separate folder. Perhaps we could add an unusedAssets folder, where future assets can be stored. It probably makes sense to organize such assets into subfolders which mirror the structure of the root folder.

When we are ready to use an asset, we can move it back into the normal folder structure. There is one sided safety there, in that an asset would need to be in the normal folder structure to be found by the game. Failure to move the asset should result in failures to load the data during development and testing. That could be made safer by doing eager loads of assets, so we don't run into the case of not finding a packaging bug because we never execute the code that needs to load the asset. The other side of the safety problem is we might potentially include assets that aren't actually used, and just not realize it. As sorting assets into an unused folder is a manual process, it's possible some assets will be missed, and will continue to be included in release packages without being used by the release.

Related issue:

@DanRStevens
Copy link
Member Author

In case this helps with sorting, I've compared the current repository to the latest release package:
diff -r -q data/ releaseData/

Files data/maps/ganymede_01_a.png and releaseData/maps/ganymede_01_a.png differ
Only in data/maps: ganymede_02_a.png
Only in data/maps: ganymede_02_b.png
Only in data/maps: ganymede_03_a.png
Only in data/maps: ganymede_03_b.png
Only in data/maps: ganymede_04_a.png
Only in data/maps: ganymede_04_b.png
Only in data/maps: ganymede_05_a.png
Only in data/maps: ganymede_05_b.png
Only in data/maps: ganymede_06_a.png
Only in data/maps: ganymede_06_b.png
Only in data/maps: mars_01_a.png
Only in data/maps: mars_01_b.png
Only in data/maps: mars_02_a.png
Only in data/maps: mars_02_b.png
Only in data/maps: mars_03_a.png
Only in data/maps: mars_03_b.png
Files data/maps/mars_04_a.png and releaseData/maps/mars_04_a.png differ
Only in data/maps: mars_05_a.png
Only in data/maps: mars_05_b.png
Files data/maps/merc_01_a.png and releaseData/maps/merc_01_a.png differ
Only in data/maps: merc_02_a.png
Only in data/maps: merc_02_b.png
Only in data/maps: merc_03_a.png
Only in data/maps: merc_03_b.png
Only in data/maps: merc_04_a.png
Only in data/maps: merc_04_b.png
Only in data/maps: merc_05_a.png
Only in data/maps: merc_05_b.png
Only in data/maps: merc_06_a.png
Only in data/maps: merc_06_b.png
Only in data/maps: merc_07_a.png
Only in data/maps: merc_07_b.png
Only in data/maps: merc_08_a.png
Only in data/maps: merc_08_b.png
Only in data/maps: pluto_01_a.png
Only in data/maps: pluto_01_b.png
Only in releaseData/maps: pluto_01.png
Only in data/maps: pluto_02_a.png
Only in data/maps: pluto_02_b.png
Only in releaseData/maps: pluto_02.png
Only in data/maps: pluto_03_a.png
Only in data/maps: pluto_03_b.png
Only in releaseData/maps: pluto_03.png
Files data/maps/pluto_04_a.png and releaseData/maps/pluto_04_a.png differ
Files data/maps/pluto_04_b.png and releaseData/maps/pluto_04_b.png differ
Only in data/structures: maintenance.png
Files data/structures/maintenance.sprite and releaseData/structures/maintenance.sprite differ
Files data/structures/roads.sprite and releaseData/structures/roads.sprite differ
Only in data/: StructureTypes.xml
Files data/tech0-1.xml and releaseData/tech0-1.xml differ
Files data/ui/icons.png and releaseData/ui/icons.png differ
Only in releaseData/ui/interface: lab.png

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant