Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedbacks & Bugs on Get Apps By User #137

Open
Buwujiu opened this issue Jan 6, 2025 · 0 comments · May be fixed by #149
Open

Feedbacks & Bugs on Get Apps By User #137

Buwujiu opened this issue Jan 6, 2025 · 0 comments · May be fixed by #149
Assignees
Labels
bug Something isn't working

Comments

@Buwujiu
Copy link
Contributor

Buwujiu commented Jan 6, 2025

Feedbacks

Feedbacks for https://daco-api.pcgl-dev.cumulus.genomeinformatics.org/api-docs/#/Applications/get_applications:

  1. Add instruction to the swagger UI on how to filter by state. What are the filter states?
  2. Add instructions on how to sort. Add an example string is even better. Such as
    Example:
    [{"direction":"desc","column":"id"}]
  3. What is the first page number? 0 or 1? Would be nice to indicate it on swagger UI.
  4. add total page, the current page to the response. Standardise the paging info in all endpoints.
  5. make sure the response filters the Review apps and return it to the top.
  6. Return more fields: user names, email, country.

Bugs:

  1. when enter a negative number as pageSize, endpoint returns all applications. Expected: throw an error to indicate that pageSize cannot be negative.
    Image

Sorting Rules:

Cannot sorting because sorting items are unclear, but here are the rules:

  • Applications should be sorted by application #, Updated, Status.
  • Sort By application # in ascending by default.
  • Sort by Updated in ascending by default.
  • Sort by Status: Show the “For Review” applications first by default, then sort alphabetically.
@Buwujiu Buwujiu changed the title Feedbacks on Get Apps By User Feedbacks & Bugs on Get Apps By User Jan 7, 2025
@Buwujiu Buwujiu added the bug Something isn't working label Jan 8, 2025
@surajgoraya surajgoraya linked a pull request Jan 14, 2025 that will close this issue
6 tasks
@surajgoraya surajgoraya linked a pull request Jan 14, 2025 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants