Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DataComponentTypes.INSTRUMENT to support more features #11978

Open
ShaneBeee opened this issue Jan 15, 2025 · 1 comment · May be fixed by #11925
Open

Update DataComponentTypes.INSTRUMENT to support more features #11978

ShaneBeee opened this issue Jan 15, 2025 · 1 comment · May be fixed by #11925
Labels
status: accepted Disputed bug is accepted as valid or Feature accepted as desired to be added.

Comments

@ShaneBeee
Copy link
Contributor

ShaneBeee commented Jan 15, 2025

Is your feature request related to a problem?

The problem is the current component for Instrument is lacking features.
As it stands right now the component only takes in MusicInstruments from the server.

Describe the solution you'd like.

If you look at the Instrument Component you will see it has a few features Paper is missing:

  • sound_event/sound definition: Use any sound key
  • use_duration: A non-negative float for how long the use duration is.
  • range: A non-negative float for the range of the sound.
  • description: Text component to use as the instruments description

Describe alternatives you've considered.

Using NMS or NBT to make this happen, but that isn't really a viable option for me.

Other

No response

@Doc94
Copy link
Contributor

Doc94 commented Jan 15, 2025

Exists a PR #11925 but depends in another PR for allow create a instance of MusicInstrument with the values.

@lynxplay lynxplay linked a pull request Jan 15, 2025 that will close this issue
@Lulu13022002 Lulu13022002 added status: accepted Disputed bug is accepted as valid or Feature accepted as desired to be added. and removed status: needs triage labels Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: accepted Disputed bug is accepted as valid or Feature accepted as desired to be added.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants