Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PotionSplashEvent doesn't prevent putting out fires #11981

Open
JHarris12345 opened this issue Jan 16, 2025 · 2 comments
Open

PotionSplashEvent doesn't prevent putting out fires #11981

JHarris12345 opened this issue Jan 16, 2025 · 2 comments
Labels

Comments

@JHarris12345
Copy link

Expected behavior

If you cancel the PotionSplashEvent, it should prevent putting out fires with water potions

Observed/Actual behavior

Fires are always put out regardless of cancellation

Steps/models to reproduce

  1. Throw water splash potion (or lingering) at a fire
  2. Cancel potion splash event
  3. Fire goes out

Plugin and Datapack List

N/A

Paper version

This server is running Paper version 1.21.1-132-ver/1.21.1@b48403b (2024-11-21T10:14:27Z) (Implementing API version 1.21.1-R0.1-SNAPSHOT)
You are running the latest version
Previous version: 1.21.1-DEV-164e116 (MC: 1.21.1)

Other

No response

@Doc94
Copy link
Contributor

Doc94 commented Jan 16, 2025

1.21.1 its a little old i try in latest and dont see any issue.

@Warriorrrr
Copy link
Member

We'd either need to put the logic for putting out fires to after the event calls or you can just use the entity change block event instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants