Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement again save for position of last lava contact #11991

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Doc94
Copy link
Contributor

@Doc94 Doc94 commented Jan 19, 2025

This PR resolve #11984 by adding again set the position of last lava contact, also add the Nullable annotation to that field.

@Doc94 Doc94 requested a review from a team as a code owner January 19, 2025 14:32
@Doc94
Copy link
Contributor Author

Doc94 commented Jan 19, 2025

now.. im not good with the large feature touchs... im not sure if this is the better way for handle the add again that CB patch.. or if is better fix that in the source file and the moonrise patch just need avoid deleting that...

@electronicboy
Copy link
Member

The issue here is that we don't really want to be implementing this stuff into moonrise directly, as it will just be removed on the next moonrise update

@Doc94
Copy link
Contributor Author

Doc94 commented Jan 19, 2025

The issue here is that we don't really want to be implementing this stuff into moonrise directly, as it will just be removed on the next moonrise update

then the fix its just modify the file and handle the merge conflict or exists a better way?

@electronicboy
Copy link
Member

cept there will be no merge conflict due to how this stuff is applied, we need MR to add a hook or something so that the changes don't get wiped out on every update

@Doc94 Doc94 force-pushed the fix/handle-lava-damage-for-block branch from db992d8 to 5f49c9b Compare January 19, 2025 15:34
@Doc94
Copy link
Contributor Author

Doc94 commented Jan 19, 2025

Ok i remake this... just copy the part of updateFluidHeightAndDoFluidPushing where get the last BlockPos for the fluid... and use that for update the BlockPos of lastLavaContact this require keep update that new method but avoid mess with the method touched by moonrise.

image

@lynxplay lynxplay added the type: bug Something doesn't work as it was intended to. label Jan 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something doesn't work as it was intended to.
Projects
Status: Awaiting review
Development

Successfully merging this pull request may close these issues.

EntityDamageByBlockEvent.getDamager() returning null for lava
3 participants