Skip to content
This repository has been archived by the owner on Jul 2, 2019. It is now read-only.

Missing tongue_amplitude update #16

Open
dkadish opened this issue Jan 17, 2019 · 2 comments
Open

Missing tongue_amplitude update #16

dkadish opened this issue Jan 17, 2019 · 2 comments

Comments

@dkadish
Copy link

dkadish commented Jan 17, 2019

voc/top.w

Lines 224 to 239 in 20a17d6

SPFLOAT grid_offset = 1.7;
SPFLOAT fixed_tongue_diameter = 2+(tongue_diameter-2)/1.5;
SPFLOAT tongue_amplitude = (1.5 - fixed_tongue_diameter + grid_offset);
int i;
SPFLOAT t;
SPFLOAT curve;
for(i = blade_start; i < lip_start; i++) {
t = 1.1 * M_PI *
(SPFLOAT)(tongue_index - i)/(tip_start - blade_start);
fixed_tongue_diameter = 2+(tongue_diameter-2)/1.5;
curve = tongue_amplitude * cos(t);
if(i == lip_start - 1) curve *= 0.8;
if(i == blade_start || i == lip_start - 2) curve *= 0.94;
diameters[i] = 1.5 - curve;
}

I think that an update to tongue_amplitude is missing in line 234-235. In line 226, it is updated using the value of fixed_tongue_diameter, but within the loop, the new value of fixed_tongue_diameter goes unused as tongue_amplitude is not updated...

@dkadish
Copy link
Author

dkadish commented Jan 17, 2019

On second thought, I think you can actually just remove line 234. Both fixed_tongue_diameter and tongue_amplitude are not being updated in the loop, so it is unnecessary....

@PaulBatchelor
Copy link
Owner

Thanks! Could you make a PR for this fix? Thanks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants