Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PSR-4 Compliance Issue #12

Open
awadood opened this issue Jan 5, 2021 · 3 comments
Open

PSR-4 Compliance Issue #12

awadood opened this issue Jan 5, 2021 · 3 comments

Comments

@awadood
Copy link

awadood commented Jan 5, 2021

The users with composer 2 are unable to use this package because of PSR-4 incompatibility. The following two classes from payum/iso4217 do not comply with PSR-4.

Payum\ISO4217\Tests\CurrencyTest
Payum\ISO4217\Tests\ISO4217Test

Solution:

Move both classes to a new directory "Tests" inside iso4217. 
@awadood
Copy link
Author

awadood commented Jan 5, 2021

@pierredup @makasim

@awadood
Copy link
Author

awadood commented Jan 11, 2021

@makasim @pierredup @StudioMaX @markitosgv it is requested to look into the issue. It is simply an obstacle for moving to Composer 2. Solution is really simple too which is already aforementioned. Thanks

@pierredup
Copy link
Member

@awadood This package is deprecated and replaced with the original package (see Payum/Payum#879).

Also, this should not prevent you from using Composer 2, as the affected files are just unit tests which shouldn't be loaded anyway, and composer will just generate a warning and not prevent the installation of the package

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants