Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Commenting function #32

Open
daiyanze opened this issue Dec 17, 2022 · 3 comments · May be fixed by #45
Open

Commenting function #32

daiyanze opened this issue Dec 17, 2022 · 3 comments · May be fixed by #45
Assignees
@daiyanze @panzerstadt

Comments

@daiyanze
Copy link
Contributor

daiyanze commented Dec 17, 2022 •
edited
Loading

Requirements

  • Able to disable / enable the comments from config
  • Disqus

References:
https://github.com/giscus/giscus
https://giscus.app/
@daiyanze daiyanze self-assigned this Dec 17, 2022
@daiyanze daiyanze converted this from a draft issue Dec 17, 2022
@daiyanze daiyanze moved this from 🆕 New to 🏗 In progress in [gatsby-theme-pitayan] 2023 Q1 new features Dec 17, 2022
@remiks
Copy link
Collaborator

remiks commented Dec 31, 2022

Maybe this could be a good way to solve commenting? https://www.gatsbyjs.com/plugins/gatsby-plugin-disqus/

@daiyanze
Copy link
Contributor Author

I'm not sure if I should add this plugin as a dependency since some may want to use different vendors.
(Same issue to mailchimp... This could be a nightmare...)

@remiks
Copy link
Collaborator

remiks commented Jan 12, 2023

Hmm. True.. Optional? Option to turn it off in config?

@daiyanze daiyanze mentioned this issue Jan 12, 2023
Closed
@daiyanze daiyanze moved this from 🏗 In progress to 🆕 New in [gatsby-theme-pitayan] 2023 Q1 new features Jan 13, 2023
@daiyanze daiyanze pinned this issue Jan 15, 2023
@panzerstadt panzerstadt linked a pull request Feb 23, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@daiyanze daiyanze

@panzerstadt panzerstadt

Labels
None yet
Projects
[gatsby-theme-pitayan] 2023 Q1 new features
Status: 🆕 New
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add disqus as an opt-in plugin for theme users panzerstadt/gatsby-theme-pitayan
3 participants
@remiks @daiyanze @panzerstadt